Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go 1.14 #3775

Merged
merged 2 commits into from
Mar 10, 2020
Merged

Go 1.14 #3775

merged 2 commits into from
Mar 10, 2020

Conversation

dgageot
Copy link
Contributor

@dgageot dgageot commented Mar 4, 2020

Switch to Go 1.14

@codecov
Copy link

codecov bot commented Mar 4, 2020

Codecov Report

Merging #3775 into master will not change coverage.
The diff coverage is n/a.

@nkubala
Copy link
Contributor

nkubala commented Mar 4, 2020

@dgageot can you rebase?

Will make it easier to switch to another version
of Go.

Signed-off-by: David Gageot <[email protected]>
Signed-off-by: David Gageot <[email protected]>
@dgageot
Copy link
Contributor Author

dgageot commented Mar 10, 2020

@nkubala Can you take another look, please?

Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tried out make, make cross, and gcloud builds submit on my Mac and they work fine.

@nkubala nkubala merged commit 6de4fd5 into GoogleContainerTools:master Mar 10, 2020
@mjgallag
Copy link

mjgallag commented Mar 12, 2020

@nkubala see Homebrew/homebrew-core#51233 (comment), what are the chances of this being released as a patch to v1.5.0?

@nkubala
Copy link
Contributor

nkubala commented Mar 16, 2020

@mjgallag looks like this was addressed by the homebrew folks in that PR. we'll ship this out with the release this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants